chore(ci): Switch out labeler action, define labels in workflow inline instead of by config file #31758
Conversation
github-actions
bot
added
the
system
|
Thank you, merging shortly |
|
Hi there @bsmth, I believe that replacing the hardcoded event type with a list of valid options or making the event type configurable is a worthwhile suggestion. It seems like this issue could be a significant blocker for many others as well. 😄 |
|
Hey there 👋🏻 nice to see you dropping in! After looking at quite a few actions, I think yours is looking great and I was reluctant to get rid of it, to be honest.
That was fast! Well done, I think that should cover the only viable event types that can be passed. I would really like to try this out again in future. We have a reusable workflows repo that might be a good place to add it.
Not at all, it gets a little noisy for people who are watching the repo in terms of notifications, but that's how it is sometimes with GH actions, it's tricky to test without pushing to main for some cases. Feel free to drop into our Discord, we could have a chat about it! |
Description
Use labeler action that accepts
pull_request_targetGH events instead of https://github.com/cbrgm/pr-size-labeler-action.Motivation
The pr-size-labeler-action action is really nice, but has hardcoded
GITHUB_EVENT_NAMEconsts in the Go code, seeisValidEventfunction.PRs from forks (99% of those landing here) are therefore ignored, so switching out to one with less features, but works as expected.
Related issues and pull requests